Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API documentation to code base #44

Merged
merged 11 commits into from
Jul 23, 2024
Merged

Add API documentation to code base #44

merged 11 commits into from
Jul 23, 2024

Conversation

davidallendj
Copy link
Collaborator

@davidallendj davidallendj commented Jul 17, 2024

This PR aims to add documentation describing how Magellan's internal API works and how it is designed. The goal is to make understanding the code base easier to follow and to convey the intentions of each design choice to new contributors. This should also allow reflecting on some of the design choices made thus far and target areas of the code that needs improvement.

Ideally, the API docs will be sufficient enough to use go docs and generate documentation like on pkg.go.dev.

@davidallendj davidallendj added the documentation Improvements or additions to documentation label Jul 17, 2024
@davidallendj davidallendj self-assigned this Jul 17, 2024
@davidallendj davidallendj added the not ready for review For PRs that are not ready for review label Jul 18, 2024
@davidallendj davidallendj added needs review Issues or pull requests that needs to be reviewed and removed not ready for review For PRs that are not ready for review labels Jul 23, 2024
@davidallendj davidallendj changed the title [WIP] Add API documentation to code base Add API documentation to code base Jul 23, 2024
@davidallendj
Copy link
Collaborator Author

davidallendj commented Jul 23, 2024

Most of the important functions and commands should now be documented aside from the ones that are going to be removed in the refactor. Additionally, none of the changes here should affect the current behavior or functionality of the tool.

@davidallendj davidallendj merged commit 00f9d4e into main Jul 23, 2024
@davidallendj davidallendj deleted the api-docs branch July 23, 2024 22:28
@davidallendj davidallendj removed the needs review Issues or pull requests that needs to be reviewed label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant