-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API documentation to code base #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidallendj
added
the
not ready for review
For PRs that are not ready for review
label
Jul 18, 2024
davidallendj
added
needs review
Issues or pull requests that needs to be reviewed
and removed
not ready for review
For PRs that are not ready for review
labels
Jul 23, 2024
davidallendj
changed the title
[WIP] Add API documentation to code base
Add API documentation to code base
Jul 23, 2024
Most of the important functions and commands should now be documented aside from the ones that are going to be removed in the refactor. Additionally, none of the changes here should affect the current behavior or functionality of the tool. |
davidallendj
removed
the
needs review
Issues or pull requests that needs to be reviewed
label
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add documentation describing how Magellan's internal API works and how it is designed. The goal is to make understanding the code base easier to follow and to convey the intentions of each design choice to new contributors. This should also allow reflecting on some of the design choices made thus far and target areas of the code that needs improvement.
Ideally, the API docs will be sufficient enough to use
go docs
and generate documentation like on pkg.go.dev.